Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): limit typing_extensions classes to those available in min version #7490

Merged
merged 1 commit into from
Mar 7, 2023
Merged

fix(ingest): limit typing_extensions classes to those available in min version #7490

merged 1 commit into from
Mar 7, 2023

Conversation

cburroughs
Copy link
Contributor

@cburroughs cburroughs commented Mar 3, 2023 •
edited
Loading

Depending on python versions, the minimum typing_extensions is
>=3.7.4.3 or >=3.10.0.2. (And needs to stay that way for Airflow.)
However, typing_extensions.Self is only available starting in 4.0.0 https://github.com/python/typing_extensions/blob/main/CHANGELOG.md#added-in-version-400

This partially reverts #7313 to avoid the use of
typing_extensions.Self.

Fixes #7370

Checklist

  • [ X] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • [ x] Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@cburroughs
fix(ingest): limt typing_extensions classes to those available in min…
521eff7 
… version

Depending on python versions, the minimum typing_extensions is
>=3.7.4.3 or >=3.10.0.2. (And needs to stay that way for Airflow.)
However, typing_extensions.Self is only available starting in 4.0.0
https://github.com/python/typing_extensions/blob/main/CHANGELOG.md#added-in-version-400

This partially reverts datahub-project#7313 to avoid the use of
typing_extensions.Self.

Fixes datahub-project#7370
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 3, 2023
@cburroughs cburroughs changed the title fix(ingest): limt typing_extensions classes to those available in min version fix(ingest): limit typing_extensions classes to those available in min version Mar 3, 2023
hsheth2
hsheth2 approved these changes Mar 7, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a bummer that we need to do this - I felt typing_extensions.Self produced much more readable code

@hsheth2 hsheth2 merged commit 86264b1 into datahub-project:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typing-extensions import error with 0.10.0.1
2 participants
@cburroughs @hsheth2