Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): prevent logging from blowing up on TypeErrors #7497

Merged
merged 1 commit into from
Mar 3, 2023
Merged

fix(ingest): prevent logging from blowing up on TypeErrors #7497

merged 1 commit into from
Mar 3, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Mar 3, 2023

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 3, 2023
asikowitz
asikowitz approved these changes Mar 3, 2023
View reviewed changes
Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Def a common mistake, nice to catch this

metadata-ingestion/src/datahub/ingestion/source/looker/lookml_source.py
@@ -1501,8 +1501,7 @@ def get_workunits_internal(self) -> Iterable[MetadataWorkUnit]:
p_ref = p_checkout_dir.resolve()
except Exception as e:
logger.warning(
f"Failed to clone remote project {project}. This can lead to failures in parsing lookml files later on",
e,
f"Failed to clone remote project {project}. This can lead to failures in parsing lookml files later on: {e}",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can do logger.warning(..., exc_info=True) if you want? Although that includes a stack trace

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I explicitly want the error message but not the full stack trace

@hsheth2 hsheth2 merged commit 01ee351 into datahub-project:master Mar 3, 2023
@hsheth2 hsheth2 deleted the logging-errors branch March 3, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hsheth2 @asikowitz