fix(): Fix Query Detail Modal Scroll + add misc log messages #7530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o jj--fix-queries-scroll-modal
github-actions
bot
added
devops
aditya-radhakrishnan
approved these changes
Mar 9, 2023
| @@ -85,7 +85,7 @@ public void checkSystemVersion(final ConsumerRecord<String, GenericRecord> consu | |||
| if (expectedVersion.equals(event.getVersion())) { | |||
| IS_UPDATED.getAndSet(true); | |||
| } else { | |||
| log.debug("System version is not up to date: {}", expectedVersion); | |||
| log.info("System version is not up to date: {}. Waiting for datahub-upgrade to complete...", expectedVersion); | |||
There was a problem hiding this comment.
Are we worried at all that this might be noisy?
There was a problem hiding this comment.
not. its critical we add this
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Mar 11, 2023
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Mar 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Status
Ready to review
Checklist