Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): fix edge cases + interface cleanup for file-system APIs #7533

Merged
merged 3 commits into from
Mar 13, 2023
Merged

feat(ingest): fix edge cases + interface cleanup for file-system APIs #7533

merged 3 commits into from
Mar 13, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Mar 10, 2023

  • Sets pickle as the default serde method
  • Fixes a subtle bug around the close() method
  • Adds much better comments

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 10, 2023
asikowitz
asikowitz approved these changes Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking out the previous PR I missed while I was out now, but this looks good to me!

@hsheth2 hsheth2 merged commit fbfe43b into datahub-project:master Mar 13, 2023
@hsheth2 hsheth2 deleted the fs-apis branch March 13, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hsheth2 @asikowitz