-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): build and upload Python wheels in CI #7537
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really familiar with any of this but seems reasonable enough to me
@@ -171,6 +171,9 @@ task testSlowIntegration(type: Exec, dependsOn: [installDevTest]) { | |||
task docGen(type: Exec, dependsOn: [codegen, installDevTest]) { | |||
commandLine 'bash', '-c', "source ${venv_name}/bin/activate && ./scripts/docgen.sh" | |||
} | |||
task buildWheel(type: Exec, dependsOn: [install, codegen]) { | |||
commandLine 'bash', '-c', "source ${venv_name}/bin/activate && " + 'pip install build && RELEASE_VERSION="\${RELEASE_VERSION:-0.0.0.dev1}" RELEASE_SKIP_TEST=1 RELEASE_SKIP_UPLOAD=1 ./scripts/release.sh' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do 0.0.0.dev0 and 0.0.0.dev1 represent? I see we have:
def is_dev_mode() -> bool:
return __version__.endswith("dev0")
so does that mean 0.0.0.dev1 is not dev mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, because it's not installed in "editable" mode.
<url>/artifacts/wheels/acryl-datahub-0.0.0.dev1-py3-none-any.whl
(and similar)Checklist