Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): try Qodana Scan for quality #7560

Merged
merged 3 commits into from
Mar 14, 2023
Merged

chore(ci): try Qodana Scan for quality #7560

merged 3 commits into from
Mar 14, 2023

Conversation

anshbansal
Copy link
Collaborator

@anshbansal anshbansal commented Mar 13, 2023 •
edited
Loading

Adds a scan https://github.com/datahub-project/datahub/actions/runs/4406880321. If we go to summary we can download qodana-report which can be viewed as explained here https://www.jetbrains.com/help/qodana/html-report.html

It shows up as
image

Trying to upload the report to github code scans

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@anshbansal anshbansal marked this pull request as draft March 13, 2023 15:22
@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Mar 13, 2023
@anshbansal anshbansal changed the title chore(ci): try Qodana Scan for quality WIP chore(ci): try Qodana Scan for quality Mar 13, 2023
@anshbansal anshbansal marked this pull request as ready for review March 13, 2023 16:59
@anshbansal anshbansal changed the title WIP chore(ci): try Qodana Scan for quality chore(ci): try Qodana Scan for quality Mar 13, 2023
@anshbansal anshbansal merged commit 64b4d0b into master Mar 14, 2023
@anshbansal anshbansal deleted the aseem-add-code-quality-scan branch March 14, 2023 08:56
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Mar 15, 2023
@anshbansal @shirshanka
chore(ci): try Qodana Scan for quality (datahub-project#7560)
350db81
yoonhyejin pushed a commit to yoonhyejin/datahub-project-forked that referenced this pull request Mar 15, 2023
@anshbansal
chore(ci): try Qodana Scan for quality (datahub-project#7560)
89668f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedro93 pedro93 pedro93 approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anshbansal @pedro93