feat(ingest/tableau): extract lineage from csql queries #7561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
maaaikoool
force-pushed
the
ingest-lineage-from-unsupported-csql-tables
branch
from
d098180
to
53badba
Compare
mayurinehate
suggested changes
Mar 16, 2023
metadata-ingestion/tests/integration/tableau/tableau_unsupported_csql_golden.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Mayuri Nehate <33225191+mayurinehate@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mayurinehate
suggested changes
Mar 23, 2023
metadata-ingestion/tests/integration/tableau/tableau_unsupported_csql_golden.json
Outdated
Show resolved
Hide resolved
This reverts commit baff4c9.
maaaikoool
force-pushed
the
ingest-lineage-from-unsupported-csql-tables
branch
from
0627bfd
to
de72882
Compare
metadata-ingestion/tests/integration/tableau/test_tableau_ingest.py
Outdated
Show resolved
Hide resolved
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #7561 +/- ##
==========================================
- Coverage 74.87% 67.07% -7.81%
==========================================
Files 353 353
Lines 35386 35407 +21
==========================================
- Hits 26496 23748 -2748
- Misses 8890 11659 +2769
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 76 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
maaaikoool
force-pushed
the
ingest-lineage-from-unsupported-csql-tables
branch
from
4ef9a69
to
ec55b44
Compare
hsheth2
approved these changes
Apr 10, 2023
5 tasks
yoonhyejin
pushed a commit
that referenced
this pull request
Apr 19, 2023
Co-authored-by: Mayuri Nehate <33225191+mayurinehate@users.noreply.github.com> Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... that contain unsupported queries.
Context
The tableau ingestion uses the lineage provided by the Tableau metadata catalog API.
However, Tableau has limited support for lineage in custom SQL tables. This results in incomplete lineage. The issue has been reported many times: 1, 2, 3
Proposed solution
We are adding a new configuration (default disabled) that will enable parsing the custom SQL table queries so that we can have full lineage. The config also contains a mapping of the tableau database name to the desired name.
Checklist
Closes #5854