Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs-website): add docs on creating users and groups #7574

Merged
merged 13 commits into from
Mar 24, 2023
Merged

feat(docs-website): add docs on creating users and groups #7574

merged 13 commits into from
Mar 24, 2023

Conversation

yoonhyejin
Copy link
Collaborator

@yoonhyejin yoonhyejin commented Mar 14, 2023 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Demo

https://yoonhyejin.github.io/datahub-project-forked/docs/tools/tutorials/creating-users-and-groups

Description

This PR has to be merged with CLI improvement on creating users/groups out of yaml ( cf; #7595 )

resolves DR-374

@github-actions github-actions bot added the docs Issues and Improvements to docs label Mar 14, 2023
@shirshanka shirshanka mentioned this pull request Mar 15, 2023
Merged
5 tasks
@hsheth2
Copy link
Collaborator

hsheth2 commented Mar 23, 2023

@yoonhyejin #7595 is now in

laulpogan
laulpogan approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@laulpogan laulpogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yoonhyejin yoonhyejin merged commit 918718e into master Mar 24, 2023
@yoonhyejin yoonhyejin deleted the docs/add-users-groups branch March 24, 2023 02:52
yoonhyejin added a commit that referenced this pull request Apr 3, 2023
@yoonhyejin @shirshanka
feat(docs-website): add docs on creating users and groups (#7574)
91da6e4 
Co-authored-by: Hyejin Yoon <yoonhyejin@Hyejins-MacBook-Pro.local>
Co-authored-by: Shirshanka Das <shirshanka@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka left review comments

@laulpogan laulpogan laulpogan approved these changes

Assignees
No one assigned
Labels
docs Issues and Improvements to docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yoonhyejin @hsheth2 @shirshanka @laulpogan