Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): add docs on lineage #7576

Merged
merged 2 commits into from Mar 15, 2023
Merged

feat(docs): add docs on lineage #7576

merged 2 commits into from Mar 15, 2023

Conversation

yoonhyejin
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Demo

https://yoonhyejin.github.io/datahub-project-forked/docs/tools/tutorials/adding-lineage

@yoonhyejin yoonhyejin changed the title feat: add docs on lineage feat(docs): add docs on lineage Mar 14, 2023
@github-actions github-actions bot added the docs Issues and Improvements to docs label Mar 14, 2023
laulpogan
laulpogan reviewed Mar 15, 2023
View reviewed changes
docs/tools/tutorials/adding-lineage.md
Note that you can create a list of edges. For example, if you want to assign multiple upstream entities to a downstream entity, you can do the following.


```json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a great note!

laulpogan
laulpogan approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@laulpogan laulpogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I'd say we can ship it :)

@yoonhyejin yoonhyejin merged commit d8c73b0 into master Mar 15, 2023
27 of 31 checks passed
@yoonhyejin yoonhyejin deleted the docs/add-lineage branch March 15, 2023 23:19
iprentic pushed a commit to iprentic/datahub that referenced this pull request Mar 20, 2023
@yoonhyejin
feat(docs): add docs on lineage (datahub-project#7576)
18f3601 
Co-authored-by: Hyejin Yoon <yoonhyejin@Hyejins-MacBook-Pro.local>
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Mar 22, 2023
@yoonhyejin @shirshanka
feat(docs): add docs on lineage (datahub-project#7576)
6110833 
Co-authored-by: Hyejin Yoon <yoonhyejin@Hyejins-MacBook-Pro.local>
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Mar 22, 2023
@yoonhyejin @shirshanka
feat(docs): add docs on lineage (datahub-project#7576)
2f6cde3 
Co-authored-by: Hyejin Yoon <yoonhyejin@Hyejins-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laulpogan laulpogan laulpogan approved these changes

@hsheth2 hsheth2 Awaiting requested review from hsheth2

Assignees
No one assigned
Labels
docs Issues and Improvements to docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yoonhyejin @laulpogan