chore(ci): update dependencies, fix smoke image build #7580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
devops
hsheth2
reviewed
Mar 14, 2023
hsheth2
approved these changes
Mar 15, 2023
| @@ -18,7 +18,9 @@ RUN apt-get update && apt-get install -y \ | |||
| RUN DEBIAN_FRONTEND=noninteractive apt-get install -y openjdk-11-jdk | |||
|
|
|||
| COPY . /datahub-src | |||
| RUN cd /datahub-src/datahub-ingestion && \ | |||
| ARG RELEASE_VERSION | |||
There was a problem hiding this comment.
I may be missing something, but how was this not required previously?
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| echo "tag=$(get_tag)" >> $GITHUB_OUTPUT | ||
| - name: Compute Python Release Version | ||
| id: python_release_version | ||
| run: | |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:51: Double quote to prevent globbing and word splitting [shellcheck]
| echo "tag=$(get_tag)" >> $GITHUB_OUTPUT | ||
| - name: Compute Python Release Version | ||
| id: python_release_version | ||
| run: | |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:58: Double quote to prevent globbing and word splitting [shellcheck]
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Mar 22, 2023
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7458 did not work so just adding another gradle task for installing all. Also updating dependencies while at it.
Checklist