New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingestion): powerbi # support platform instance #7583
Merged
jjoyce0510
merged 15 commits into
datahub-project:master
from
siddiquebagwan:master+powerbi-platform-instance
Mar 21, 2023
Merged
Changes from 2 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c3007a9
platform instance support
siddiquebagwan-gslab 526b00a
rename the test-case
siddiquebagwan-gslab 8884489
Merge branch 'master' into master+powerbi-platform-instance
siddiquebagwan 88508ec
Merge branch 'master' into master+powerbi-platform-instance
jjoyce0510 db6a65f
Merge branch 'master' into master+powerbi-platform-instance
siddiquebagwan-gslab 7117024
doc update
siddiquebagwan-gslab 197b5d9
Merge branch 'master+powerbi-platform-instance' of github.com:mohdsid…
siddiquebagwan-gslab dd2a542
Merge branch 'master' into master+powerbi-platform-instance
siddiquebagwan 86fa843
Merge branch 'master' into master+powerbi-platform-instance
siddiquebagwan 2de7fa4
Merge branch 'master' into master+powerbi-platform-instance
siddiquebagwan-gslab e0394ea
update golden files
siddiquebagwan-gslab cbc4c16
Merge branch 'master+powerbi-platform-instance' of github.com:acrylda…
siddiquebagwan-gslab 30c3771
trigger build
siddiquebagwan-gslab 89d6d0a
Merge branch 'master' into master+powerbi-platform-instance
siddiquebagwan 43abef7
Merge branch 'master' into master+powerbi-platform-instance
siddiquebagwan File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -233,9 +233,10 @@ def to_datahub_dataset( | |
|
||
for table in dataset.tables: | ||
# Create a URN for dataset | ||
ds_urn = builder.make_dataset_urn( | ||
ds_urn = builder.make_dataset_urn_with_platform_instance( | ||
platform=self.__config.platform_name, | ||
name=self.assets_urn_to_lowercase(table.full_name), | ||
platform_instance=self.__config.platform_instance, | ||
env=self.__config.env, | ||
) | ||
|
||
|
@@ -301,7 +302,9 @@ def to_datahub_chart_mcp( | |
logger.info(f"Converting tile {tile.title}(id={tile.id}) to chart") | ||
# Create a URN for chart | ||
chart_urn = builder.make_chart_urn( | ||
self.__config.platform_name, tile.get_urn_part() | ||
platform=self.__config.platform_name, | ||
platform_instance=self.__config.platform_instance, | ||
name=tile.get_urn_part(), | ||
) | ||
|
||
logger.info(f"{Constant.CHART_URN}={chart_urn}") | ||
|
@@ -401,7 +404,9 @@ def to_datahub_dashboard_mcp( | |
""" | ||
|
||
dashboard_urn = builder.make_dashboard_urn( | ||
self.__config.platform_name, dashboard.get_urn_part() | ||
platform=self.__config.platform_name, | ||
platform_instance=self.__config.platform_instance, | ||
name=dashboard.get_urn_part(), | ||
) | ||
|
||
chart_urn_list: List[str] = self.to_urn_set(chart_mcps) | ||
|
@@ -514,7 +519,10 @@ def append_container_mcp( | |
entity_urn: str, | ||
) -> None: | ||
if self.__config.extract_workspaces_to_containers: | ||
container_key = workspace.get_workspace_key(self.__config.platform_name) | ||
container_key = workspace.get_workspace_key( | ||
platform_name=self.__config.platform_name, | ||
platform_instance=self.__config.platform_instance, | ||
) | ||
container_urn = builder.make_container_urn( | ||
guid=container_key.guid(), | ||
) | ||
|
@@ -672,7 +680,9 @@ def to_chart_mcps( | |
logger.debug(f"Converting page {page.displayName} to chart") | ||
# Create a URN for chart | ||
chart_urn = builder.make_chart_urn( | ||
self.__config.platform_name, page.get_urn_part() | ||
platform=self.__config.platform_name, | ||
platform_instance=self.__config.platform_instance, | ||
name=page.get_urn_part(), | ||
) | ||
|
||
logger.debug(f"{Constant.CHART_URN}={chart_urn}") | ||
|
@@ -741,7 +751,9 @@ def report_to_dashboard( | |
""" | ||
|
||
dashboard_urn = builder.make_dashboard_urn( | ||
self.__config.platform_name, report.get_urn_part() | ||
platform=self.__config.platform_name, | ||
platform_instance=self.__config.platform_instance, | ||
name=report.get_urn_part(), | ||
) | ||
|
||
chart_urn_list: List[str] = self.to_urn_set(chart_mcps) | ||
|
@@ -878,8 +890,12 @@ def report_to_datahub_work_units( | |
@platform_name("PowerBI") | ||
@config_class(PowerBiDashboardSourceConfig) | ||
@support_status(SupportStatus.CERTIFIED) | ||
@capability(SourceCapability.DESCRIPTIONS, "Enabled by default") | ||
@capability(SourceCapability.PLATFORM_INSTANCE, "Enabled by default") | ||
@capability(SourceCapability.PLATFORM_INSTANCE, "Enabled by default") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this duplicated? |
||
@capability( | ||
SourceCapability.OWNERSHIP, "On by default but can disabled by configuration" | ||
SourceCapability.OWNERSHIP, | ||
"Disabled by default, configured using `extract_ownership`", | ||
) | ||
class PowerBiDashboardSource(StatefulIngestionSourceBase): | ||
""" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!