Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(policies): add missing policies, add check to prevent problems #7586

Merged
merged 4 commits into from
Mar 16, 2023
Merged

fix(policies): add missing policies, add check to prevent problems #7586

merged 4 commits into from
Mar 16, 2023

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Mar 14, 2023
jjoyce0510
jjoyce0510 reviewed Mar 15, 2023
View reviewed changes
metadata-service/war/src/main/resources/boot/policies.json
@@ -98,7 +98,13 @@
"MANAGE_DOMAINS",
"MANAGE_TESTS",
"MANAGE_GLOSSARIES",
"MANAGE_TAGS"
"MANAGE_TAGS",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

jjoyce0510
jjoyce0510 approved these changes Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM onci ci is green!

@anshbansal anshbansal merged commit 2ef26e8 into master Mar 16, 2023
@anshbansal anshbansal deleted the aseem-add-check-policies branch March 16, 2023 04:19
iprentic pushed a commit to iprentic/datahub that referenced this pull request Mar 20, 2023
@anshbansal @jjoyce0510
fix(policies): add missing policies, add check to prevent problems (d…
f6387a1 
…atahub-project#7586)

Co-authored-by: John Joyce <john@acryl.io>
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Mar 22, 2023
@anshbansal @jjoyce0510 @shirshanka
fix(policies): add missing policies, add check to prevent problems (d…
e659f66 
…atahub-project#7586)

Co-authored-by: John Joyce <john@acryl.io>
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Mar 22, 2023
@anshbansal @jjoyce0510 @shirshanka
fix(policies): add missing policies, add check to prevent problems (d…
aae9a74 
…atahub-project#7586)

Co-authored-by: John Joyce <john@acryl.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anshbansal @jjoyce0510