Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): show image pull progress in quickstart #7593

Merged
merged 3 commits into from
Mar 16, 2023
Merged

feat(cli): show image pull progress in quickstart #7593

merged 3 commits into from
Mar 16, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Mar 15, 2023

Also cleans up the logging a bit.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 15, 2023
jjoyce0510
jjoyce0510 approved these changes Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once Ci passes lets get it in!

@anshbansal anshbansal merged commit bcda510 into datahub-project:master Mar 16, 2023
iprentic pushed a commit to iprentic/datahub that referenced this pull request Mar 20, 2023
@hsheth2 @jjoyce0510
feat(cli): show image pull progress in quickstart (datahub-project#7593)
98d5cc3 
Co-authored-by: John Joyce <john@acryl.io>
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Mar 22, 2023
@hsheth2 @jjoyce0510 @shirshanka
feat(cli): show image pull progress in quickstart (datahub-project#7593)
5468b70 
Co-authored-by: John Joyce <john@acryl.io>
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Mar 22, 2023
@hsheth2 @jjoyce0510 @shirshanka
feat(cli): show image pull progress in quickstart (datahub-project#7593)
1598e9a 
Co-authored-by: John Joyce <john@acryl.io>
@hsheth2 hsheth2 deleted the quickstart-show-pull branch February 14, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedro93 pedro93 pedro93 approved these changes

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hsheth2 @pedro93 @jjoyce0510 @anshbansal