-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(search): tags with colons exercises search with urns, must follow… #7602
fix(search): tags with colons exercises search with urns, must follow… #7602
Conversation
@@ -24,6 +24,8 @@ public com.linkedin.metadata.query.SearchFlags apply(@Nonnull final SearchFlags | |||
com.linkedin.metadata.query.SearchFlags result = new com.linkedin.metadata.query.SearchFlags(); | |||
if (searchFlags.getFulltext() != null) { | |||
result.setFulltext(searchFlags.getFulltext()); | |||
} else { | |||
result.setFulltext(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when do we not want to use fulltext?
import static com.linkedin.datahub.graphql.TestUtils.getMockAllowContext; | ||
|
||
|
||
public class SearchResolverTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Huge thank you for adding the SearchResolver unit test- long overdue!
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… fulltext
Checklist