Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add new code examples on creating entities & fix minor typos #7613

Merged
merged 3 commits into from
Mar 17, 2023
Merged

docs: add new code examples on creating entities & fix minor typos #7613

merged 3 commits into from
Mar 17, 2023

Conversation

yoonhyejin
Copy link
Collaborator

@yoonhyejin yoonhyejin commented Mar 16, 2023 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

resolves DR-345

@github-actions github-actions bot added docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX labels Mar 16, 2023
@yoonhyejin yoonhyejin closed this Mar 16, 2023
@yoonhyejin yoonhyejin reopened this Mar 16, 2023
laulpogan
laulpogan approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@laulpogan laulpogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good- there's a warning about no newline at end of file but I don't think that should break anything

@github-actions github-actions bot removed the product PR or Issue related to the DataHub UI/UX label Mar 16, 2023
@yoonhyejin yoonhyejin merged commit 3855538 into master Mar 17, 2023
@yoonhyejin yoonhyejin deleted the docs/add-snippets branch March 17, 2023 01:07
iprentic pushed a commit to iprentic/datahub that referenced this pull request Mar 20, 2023
@yoonhyejin
docs: add new code examples on creating entities & fix minor typos (d…
638fa23 
…atahub-project#7613)

Co-authored-by: Hyejin Yoon <yoonhyejin@Hyejins-MacBook-Pro.local>
Co-authored-by: Hyejin Yoon <yoonhyejin@ip-192-168-0-10.us-west-2.compute.internal>
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Mar 22, 2023
@yoonhyejin @shirshanka
docs: add new code examples on creating entities & fix minor typos (d…
81fd793 
…atahub-project#7613)

Co-authored-by: Hyejin Yoon <yoonhyejin@Hyejins-MacBook-Pro.local>
Co-authored-by: Hyejin Yoon <yoonhyejin@ip-192-168-0-10.us-west-2.compute.internal>
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Mar 22, 2023
@yoonhyejin @shirshanka
docs: add new code examples on creating entities & fix minor typos (d…
50311eb 
…atahub-project#7613)

Co-authored-by: Hyejin Yoon <yoonhyejin@Hyejins-MacBook-Pro.local>
Co-authored-by: Hyejin Yoon <yoonhyejin@ip-192-168-0-10.us-west-2.compute.internal>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laulpogan laulpogan laulpogan approved these changes

Assignees
No one assigned
Labels
docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yoonhyejin @laulpogan