Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(search): missing model updates and tests #7617

Merged
merged 4 commits into from
Mar 21, 2023
Merged

fix(search): missing model updates and tests #7617

merged 4 commits into from
Mar 21, 2023

Conversation

david-leifker
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Mar 17, 2023
RyanHolstien
RyanHolstien reviewed Mar 17, 2023
View reviewed changes
...o/src/main/java/com/linkedin/metadata/search/elasticsearch/indexbuilder/SettingsBuilder.java
@@ -117,6 +119,7 @@ public class SettingsBuilder {
public static final List<String> INDEX_TOKEN_FILTERS = ImmutableList.of(
ASCII_FOLDING,
MULTIFILTER,
TRIM,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this trigger a reindex?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added, but also the stop words so 2 birds, one stone.

RyanHolstien
RyanHolstien approved these changes Mar 17, 2023
View reviewed changes
Copy link
Collaborator

@RyanHolstien RyanHolstien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, if yes to reindex retriggering we should add a note into Updating DataHub

@vercel
Copy link

vercel bot commented Mar 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
docs-website ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 21, 2023 at 4:07AM (UTC)

@vercel vercel bot temporarily deployed to Preview March 21, 2023 04:07 Inactive
@david-leifker david-leifker reopened this Mar 21, 2023
@david-leifker david-leifker merged commit faf0ac1 into datahub-project:master Mar 21, 2023
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Mar 22, 2023
@david-leifker @jjoyce0510 @shirshanka
fix(search): missing model updates and tests (datahub-project#7617)
bf206ea 
Co-authored-by: John Joyce <john@acryl.io>
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Mar 22, 2023
@david-leifker @jjoyce0510 @shirshanka
fix(search): missing model updates and tests (datahub-project#7617)
312562d 
Co-authored-by: John Joyce <john@acryl.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanHolstien RyanHolstien RyanHolstien approved these changes

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

@iprentic iprentic Awaiting requested review from iprentic

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@david-leifker @RyanHolstien @jjoyce0510