fix(docker):The datahub-frontend service failed to start when executing dev.sh #7616 #7618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
devops
|
@jjoyce0510 Could you help review this pr? Thanks |
meyerkev
reviewed
Apr 10, 2023
docker/datahub-frontend/Dockerfile
Outdated
| && apk --no-cache add openjdk11-jre --repository=http://dl-cdn.alpinelinux.org/alpine/edge/community | ||
| && apk --no-cache add openjdk11-jre --repository=http://dl-cdn.alpinelinux.org/alpine/edge/community \ | ||
| && wget https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases/download/v1.18.0/opentelemetry-javaagent.jar -O opentelemetry-javaagent.jar \ | ||
| && wget https://repo1.maven.org/maven2/io/prometheus/jmx/jmx_prometheus_javaagent/0.16.1/jmx_prometheus_javaagent-0.16.1.jar -O jmx_prometheus_javaagent.jar |
There was a problem hiding this comment.
Why are we rolling back from 0.17 to 0.16? What does that get us?
I ask because the old library/jmx_prometheus_javaagent.jar:1 trips over the Snakeyaml bug here: https://www.veracode.com/blog/research/resolving-cve-2022-1471-snakeyaml-20-release-0 and therefore we probably ought to be migrating forward to 0.18.x
There was a problem hiding this comment.
oh, this is my typo. It should be 0.17. I will update this patch later.
yangjiandan
force-pushed
the
Datahub-7616
branch
2 times, most recently
from
ebbbeb7
to
69d26e5
Compare
|
@meyerkev please help me review this pr, thanks! |
anshbansal
added
the
community-contribution
|
@shirshanka Could you help me review this pr? |
RyanHolstien
approved these changes
Dec 7, 2023
RyanHolstien
added
the
merge-pending-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After applying this patch, when MONITORING=true the datahub-frontend service also can start normally
Checklist