-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
servlet(config): add search configuration endpoint #7641
Merged
david-leifker
merged 5 commits into
datahub-project:master
from
david-leifker:search-configuration
Apr 13, 2023
Merged
servlet(config): add search configuration endpoint #7641
david-leifker
merged 5 commits into
datahub-project:master
from
david-leifker:search-configuration
Apr 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metadata-service/servlet/src/main/java/com/datahub/gms/servlet/SearchConfigCsv.java
Outdated
Show resolved
Hide resolved
Pending review of where and how the endpoint should be exposed |
Deployment failed with the following error:
|
shirshanka
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yoonhyejin
pushed a commit
that referenced
this pull request
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create an endpoint in GMS which will return a csv of the search weights for each entity. Useful for debugging search rankings. A few rows are shown below. The endpoint is exposed on GMS as
http://localhost:8080/config/search/export?format=csv
or the frontend ashttp://localhost:8080/api/gms/config/search/export?format=csv
Checklist