fix(ui): Address regression in column usage stats + add unit test #7645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix regression in usage stats revert unnecessary change Finalizng unit tests
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aditya-radhakrishnan
approved these changes
Mar 21, 2023
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Mar 22, 2023
…tahub-project#7645) Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com>
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Mar 22, 2023
…tahub-project#7645) Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In a recent PR, we attempted to optimize the getDataset query that is issued on the dataset entity page. In doing so we mistakenly removed some data that was required for render the usage of a single column in the past month. In this PR, we correct the regression and add a unit test to prevent future issues.
Status
Ready for review. WIll also replicate to OSS.
Checklist