Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pre-commit #7680

Merged
merged 7 commits into from
Mar 31, 2023
Merged

feat: add pre-commit #7680

merged 7 commits into from
Mar 31, 2023

Conversation

yoonhyejin
Copy link
Collaborator

@yoonhyejin yoonhyejin commented Mar 24, 2023 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Description

  • Create a pre-commit to avoid failure on yarnLint and prevent unnecessary ci/cd runs
  • Runs autoflake, flake8, black, isort : any other recommendations are welcome

resolves DR-375

@yoonhyejin yoonhyejin marked this pull request as ready for review March 24, 2023 06:02
hsheth2
hsheth2 reviewed Mar 25, 2023
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
docs-website/README.md Outdated Show resolved Hide resolved
@yoonhyejin yoonhyejin requested a review from hsheth2 March 30, 2023 06:58
@yoonhyejin yoonhyejin merged commit 92ad720 into master Mar 31, 2023
@yoonhyejin yoonhyejin deleted the docs/pre-commit branch March 31, 2023 06:34
yoonhyejin added a commit that referenced this pull request Apr 3, 2023
@yoonhyejin
feat: add pre-commit (#7680)
891ec75 
Co-authored-by: Hyejin Yoon <yoonhyejin@Hyejins-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@laulpogan laulpogan Awaiting requested review from laulpogan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yoonhyejin @hsheth2