Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/bigquery): fix and refractor exported audit logs query #7699

Merged

Conversation

mayurinehate
Copy link
Collaborator

@mayurinehate mayurinehate commented Mar 28, 2023

Earlier when audit logs were exported in date sharded table format, the timestamp where clause was incorrectly constructed as

as

        timestamp >= "20230328"
    AND timestamp < "20230328"

instead of


        timestamp >= "2023-03-28T09:29:00Z"
    AND timestamp < "2023-03-28T10:01:00Z"

giving error Could not cast literal "20230328" to type TIMESTAMP

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 28, 2023
Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks way cleaner, thanks! Maybe one day we can merge the lineage and usage queries..... one day

@asikowitz
Copy link
Collaborator

Looks like there's conflicts from #7738, lmk if you have any questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants