Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ingest): formatting + cleanup MCPW usages #7706

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Mar 29, 2023

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2023

Codecov Report

Patch coverage: 57.14% and project coverage change: -7.90 ⚠️

Comparison is base (2eb9fe4) 74.97% compared to head (289361f) 67.07%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7706      +/-   ##
==========================================
- Coverage   74.97%   67.07%   -7.90%     
==========================================
  Files         353      353              
  Lines       35406    35398       -8     
==========================================
- Hits        26545    23744    -2801     
- Misses       8861    11654    +2793     
Flag Coverage Δ
pytest-testIntegration ?
pytest-testIntegrationBatch1 36.48% <28.57%> (-0.01%) ⬇️
pytest-testQuick 63.58% <42.85%> (+<0.01%) ⬆️
pytest-testSlowIntegration 32.98% <14.28%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
metadata-ingestion/src/datahub/cli/lite_cli.py 39.62% <ø> (ø)
...data-ingestion/src/datahub/emitter/rest_emitter.py 77.77% <ø> (ø)
...rc/datahub/ingestion/extractor/json_schema_util.py 88.68% <ø> (ø)
...ahub/ingestion/source/confluent_schema_registry.py 67.70% <ø> (ø)
...ion/src/datahub/ingestion/source/dbt/dbt_common.py 42.37% <ø> (-49.26%) ⬇️
...c/datahub/ingestion/source/looker/looker_common.py 87.62% <ø> (ø)
...c/datahub/ingestion/source/looker/looker_source.py 67.82% <ø> (ø)
...c/datahub/ingestion/source/looker/lookml_source.py 84.63% <ø> (+0.21%) ⬆️
...tahub/ingestion/source/powerbi/m_query/resolver.py 82.83% <ø> (ø)
...on/src/datahub/ingestion/source/powerbi/powerbi.py 94.33% <ø> (-1.89%) ⬇️
... and 14 more

... and 66 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@@ -891,10 +889,7 @@ def _to_metadata_events( # noqa: C901

mce = MetadataChangeEvent(proposedSnapshot=dataset_snapshot)
mcp = MetadataChangeProposalWrapper(
entityType="dataset",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is cool, we guess the type from the urn

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep - I'm trying to remove these where possible since it feels like a bunch of clutter

@hsheth2 hsheth2 merged commit 94fa62d into datahub-project:master Mar 29, 2023
@hsheth2 hsheth2 deleted the remove-inferred-mcpws branch March 29, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants