Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): support inlining code snippets from files #7712

Merged
merged 3 commits into from
Mar 30, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Mar 29, 2023

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (54a3727) 75.01% compared to head (37dbbaf) 75.01%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7712   +/-   ##
=======================================
  Coverage   75.01%   75.01%           
=======================================
  Files         353      353           
  Lines       35425    35425           
=======================================
  Hits        26574    26574           
  Misses       8851     8851           
Flag Coverage Δ
pytest-testIntegration 50.93% <ø> (ø)
pytest-testIntegrationBatch1 36.50% <ø> (+<0.01%) ⬆️
pytest-testQuick 63.61% <ø> (ø)
pytest-testSlowIntegration 33.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yoonhyejin yoonhyejin self-requested a review March 29, 2023 23:45
@hsheth2 hsheth2 enabled auto-merge (squash) March 29, 2023 23:56
@hsheth2 hsheth2 merged commit 575909e into datahub-project:master Mar 30, 2023
@hsheth2 hsheth2 deleted the inline-files branch March 30, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants