Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make demo site accessible directly from navbar #7715

Merged
merged 10 commits into from
Apr 6, 2023
Merged

feat: make demo site accessible directly from navbar #7715

merged 10 commits into from
Apr 6, 2023

Conversation

yoonhyejin
Copy link
Collaborator

@yoonhyejin yoonhyejin commented Mar 30, 2023 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Demo

Description

  • AS-IS : demo site is accessible through following steps: "Demo" in navbar -> "See Datahub In Action " docs -> "Check out the demo" button -> actual demo site
  • TO-BE : "Demo" in navbar -> actual demo site
  • keep the "See Datahub In Action " docs just in case for future use cases.

Any ideas are welcome regarding this change!

resolves DR-379

@github-actions github-actions bot added the docs Issues and Improvements to docs label Mar 30, 2023
@yoonhyejin yoonhyejin changed the title feat: make demo site quickly accessbile directly from navbar feat: make demo site accessbile directly from navbar Mar 30, 2023
@yoonhyejin yoonhyejin changed the title feat: make demo site accessbile directly from navbar feat: make demo site accessible directly from navbar Mar 30, 2023
hsheth2
hsheth2 reviewed Mar 31, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we also need update sidebar.js?

docs-website/docusaurus.config.js Show resolved Hide resolved
@yoonhyejin yoonhyejin requested a review from hsheth2 April 2, 2023 23:36
hsheth2
hsheth2 reviewed Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we actually keep a link to demo in the sidebar as well, but make it directly open the demo environment

You can do that like this: https://docusaurus.io/docs/sidebar/items#sidebar-item-link

@yoonhyejin yoonhyejin requested a review from hsheth2 April 4, 2023 22:39
@yoonhyejin yoonhyejin merged commit 7ec1daa into master Apr 6, 2023
@yoonhyejin yoonhyejin deleted the quick-demo branch April 6, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@shirshanka shirshanka Awaiting requested review from shirshanka

@jjoyce0510 jjoyce0510 Awaiting requested review from jjoyce0510

Assignees
No one assigned
Labels
docs Issues and Improvements to docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yoonhyejin @hsheth2