Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Return original exception as caused by #7722

Merged
merged 3 commits into from
Jun 7, 2023

Conversation

Jorricks
Copy link
Contributor

Currently when you authentication mechanism fails, and you are debugging why, you only get the message of the exception. In many cases that makes it that much harder to figure out what the real cause of the exception is. Therefore to smoothen the debugging, we should report the original exception as well.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Currently when you authentication mechanism fails, and you are debugging why, you only get the message of the exception.
In many cases that makes it that much harder to figure out what the real cause of the exception is.
Therefore to smoothen the debugging, we should report the original exception as well.
@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Mar 30, 2023
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! thanks for this

@laulpogan laulpogan merged commit 593fec5 into datahub-project:master Jun 7, 2023
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants