fix(ingest/snowflake): fix incorrect tag urn case, improve tag display name #7758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
mayurinehate
commented
Apr 6, 2023
| TagAssociation( | ||
| tag=make_tag_urn(self.snowflake_identifier(tag.identifier())) | ||
| ) | ||
| for tag in table.tags |
There was a problem hiding this comment.
This was generating mixed case URNs as opposed to lowercasing the urn, as is done at other places where urns for snowflake tags and other entities are generated.
asikowitz
approved these changes
Apr 6, 2023
mayurinehate
commented
Apr 7, 2023
| @@ -35,6 +35,9 @@ create user datahub_user display_name = 'DataHub' password='' default_role = dat | |||
|
|
|||
| // Grant the datahub_role to the new DataHub user. | |||
| grant role datahub_role to user datahub_user; | |||
|
|
|||
| // Optional - required if extracting lineage, usage or tags (without lineage) | |||
| grant imported privileges on database snowflake to role datahub_role; | |||
There was a problem hiding this comment.
This is added here so that its present in the block containing other permissions. Earlier this was only present in the later sections after a lot of text and it was observed that this permission gets missed leading to missing lineage after ingestion.
There was a problem hiding this comment.
thanks - this is super helpful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist