Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): replaced outdated docs command for building breaking changes of the metadata model #7759

Merged

Conversation

ArneCJacobs
Copy link
Contributor

The documentation recommended executing ./gradlew :gms:impl:build -Prest.model.compatibility=ignore to build the rest impl even if the model contains breaking changes. However, if one attempts to execute it they would get the following output:
image

Executing ./gradlew :metadata-service:restli-servlet-impl:build -Prest.model.compatibility=ignore instead gives the desired result, so I have changed this in the documentation.

@github-actions github-actions bot added the docs Issues and Improvements to docs label Apr 5, 2023
Copy link
Collaborator

@mayurinehate mayurinehate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the contribution.

@david-leifker david-leifker merged commit 041df37 into datahub-project:master Apr 10, 2023
yoonhyejin pushed a commit that referenced this pull request Apr 19, 2023
…es of the metadata model (#7759)

Co-authored-by: Shirshanka Das <shirshanka@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues and Improvements to docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants