Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(): add styles for sphinx generated python docs #7773

Merged

Conversation

jeffmerrick
Copy link
Contributor

Screen Shot 2023-04-06 at 1 53 17 PM

Screen Shot 2023-04-06 at 2 00 59 PM

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2
Copy link
Collaborator

hsheth2 commented Apr 6, 2023

@jeffmerrick looks awesome overall!

A few minor tweaks

  1. In this one, the extra spacing between in the parameters section looks a bit strange

image

  1. The formatting of these types still looks a bit clunky and hard to read. Could we make primitive types like Union, str, Optional not have such heavy formatting around them?

image

@jeffmerrick
Copy link
Contributor Author

@hsheth2 Definitely - made those tweaks:

Screen Shot 2023-04-06 at 4 47 37 PM

@jeffmerrick
Copy link
Contributor Author

@hsheth2 Updated the container style:

Screen Shot 2023-04-07 at 10 32 13 AM

@hsheth2 hsheth2 merged commit fd758de into datahub-project:master Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants