Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui) Fix tags and terms columns on nested schema fields #7782

Conversation

chriscollins3456
Copy link
Collaborator

When we updated ant design, I believe they introduced a new bug where the rowIndex for nested table rows is inconsistent depending on the method you're using. The onCell function gives the overall index as if it were a flat list of rows while the render method gives the index of the row in the nested field context (this is not how it used to work).

Therefore, the tagHoveredIndex piece of state would never line up with the row and it would never think you're hovering over it so we would never show the option to add tags and terms. Since fieldPath is unique in a schema anyways, we don't need the rowIndex here so I simply remove it.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@chriscollins3456 chriscollins3456 merged commit 1312ca9 into datahub-project:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants