doc(ingestion/tableau): Fix rendering ingestion quickstart guide #7808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix the bad image urls. |
hsheth2
reviewed
Apr 14, 2023
| <img width="75%" alt="tableau site role" src="https://raw.githubusercontent.com/datahub-project/static-assets-fork/main/imgs/guides/tableau/tableau-site-role.png"/> | ||
| </p> | ||
| <p align="center"> | ||
| <img width="75%" alt="tableau site role" src="https://raw.githubusercontent.com/datahub-project/static-assets/main/imgs/guides/tableau/tableau-site-role.png"/> |
There was a problem hiding this comment.
looks like this image was not redacted
| @@ -60,7 +60,7 @@ If you do not see the Ingestion tab, please contact your DataHub admin to grant | |||
| 6. Select Tableau | |||
|
|
|||
| <p align="center"> | |||
| <img width="70%" alt="Select Tableau from the options" src="https://raw.githubusercontent.com/datahub-project/static-assets-fork/main/imgs/guides/tableau/tableau-new-ingestion-source.png"/> | |||
| <img width="70%" alt="Select Tableau from the options" src="https://raw.githubusercontent.com/datahub-project/static-assets/main/imgs/guides/tableau/tableau-new-ingestion-source.png"/> | |||
There was a problem hiding this comment.
looks like most of these image links are broken https://docs-website-1ua8gifbf-acryldata.vercel.app/docs/quick-ingestion-guides/powerbi/setup
There was a problem hiding this comment.
Hi @hsheth2
Please verify again, I have corrected the links, however whenever from git I am trying to download or open the image, I am getting below error
The endpoint raw.githubusercontent.com is not rechable.
hsheth2
reviewed
Apr 17, 2023
| @@ -20,15 +20,15 @@ In order to configure ingestion from PowerBI, you'll first have to ensure you ha | |||
| e. On `Register an application` window fill the `Name` of application says `powerbi-app-connector` and keep other default as is | |||
|
|
|||
| <p align="center"> | |||
| <img width="75%" alt="app_registration" src="https://raw.githubusercontent.com/main/static-assets-fork/main/imgs/guides/powerbi/app-registration.png"/> | |||
| <img width="75%" alt="app_registration" src="https://raw.githubusercontent.com/main/static-assets/main/imgs/guides/powerbi/app-registration.png"/> | |||
There was a problem hiding this comment.
these links still don't work - please fix this one and the others
Suggested change
| <img width="75%" alt="app_registration" src="https://raw.githubusercontent.com/main/static-assets/main/imgs/guides/powerbi/app-registration.png"/> | |
| <img width="75%" alt="app_registration" src="https://raw.githubusercontent.com/datahub-project/static-assets/main/imgs/guides/powerbi/app-registration.png"/> |
jjoyce0510
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.