feat(ingest): Track disk usage in report #7812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
hsheth2
reviewed
Apr 13, 2023
| self.mem_info = humanfriendly.format_size(mem_usage) | ||
|
|
||
| disk_usage = psutil.disk_usage("/") |
There was a problem hiding this comment.
How expensive is this call under the hood?
There was a problem hiding this comment.
This calls https://man7.org/linux/man-pages/man3/statvfs.3.html under the hood. I can't find exact info on how expensive this is but I'm pretty sure it's just reading block-level info and should be super cheap. Locally, it runs instantly although guess there could be caching.
Going to switch to shutil though because it's in the standard library and seems to have better docs
hsheth2
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist