fix(ingest/redshift) - Remove pg_user table from metadata queries #7815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion which did not need before - Fixing a lineage query which was broken on newer redshift version
asikowitz
approved these changes
Apr 13, 2023
| schema_option, | ||
| NULL::varchar(255) as external_database | ||
| FROM SVV_REDSHIFT_SCHEMAS as s | ||
| inner join pg_catalog.pg_user_info as i on i.usesysid = s.schema_owner | ||
| -- inner join pg_catalog.pg_user_info as i on i.usesysid = s.schema_owner |
There was a problem hiding this comment.
Can we just delete this line and other commented out lines? Also, how come we need schema_owner_name at all? Could we just remove it?
github-actions
bot
added
the
ingestion
hsheth2
approved these changes
Apr 13, 2023
yoonhyejin
pushed a commit
that referenced
this pull request
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the need for pg_user table as it needed additional permission which did not need before
Fixing a lineage query which was broken on newer redshift version
Checklist