Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(models): Make assets searchable by their external URLs #7953

Conversation

jjoyce0510
Copy link
Collaborator

Summary

In this PR we add the https://github.com/searchable annotation to the externalUrl field shared across entities! This enables us to find unique assets based on their unique URL, for use within the Chrome extension :)

Tested using this search input

{
 "input": {"types": ["DATASET"], "query": "*", "start": 0, "count": 10, "orFilters": [ { "and": [ { "field": "externalUrl", "values": ["https://www.google.com/"] } ] } ] }
}

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

reverting bad changeS
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's party

@jjoyce0510 jjoyce0510 merged commit 14784fc into datahub-project:master May 5, 2023
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants