feat(snowflake): add config option to specify deny patterns for upstreams #7962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
asikowitz
approved these changes
May 8, 2023
| ): | ||
| raise ValueError( | ||
| "Can not perform Deletion Detection, Lineage Extraction, Profiling without extracting snowflake technical schema. Set `include_technical_schema` to True or disable Deletion Detection, Lineage Extraction, Profiling." | ||
| "Can not perform Deletion Detection, Profiling without extracting snowflake technical schema. Set `include_technical_schema` to True or disable Deletion Detection, Lineage Extraction, Profiling." |
There was a problem hiding this comment.
Do you want to remove the reference to lineage extraction at the end of the comment here?
| ) | ||
|
|
||
|
|
||
| def create_deny_regex_sql_filter( |
There was a problem hiding this comment.
Although will be annoying, definitely something we should test in connector tests in some way
| @@ -426,20 +447,30 @@ def view_lineage_history( | |||
| ) = 1 | |||
| """ | |||
|
|
|||
| # Note on use of `upstreams_deny_pattern`` to ignore temporary tables: | |||
Comment on lines
-715
to
-718
| AND upstream_column_table_name NOT LIKE '%.FIVETRAN\\_%\\_STAGING.%' | ||
| AND upstream_column_table_name NOT LIKE '%\\_\\_DBT\\_TMP' | ||
| AND upstream_table_name NOT LIKE '%.FIVETRAN\\_%\\_STAGING.%' | ||
| AND upstream_table_name NOT LIKE '%\\_\\_DBT\\_TMP' |
There was a problem hiding this comment.
We escape underscores here but not in DEFAULT_UPSTREAMS_DENY_LIST, just want to make sure this is ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup on #7894
Checklist