fix(ui): Open mailto link in new tab #7982
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Some Apple/Chrome users have Chrome set to handle
mailto
links by opening them in a specific webmail client (e.g. gmail). In this situation, when DataHub's "email" link is clicked, the current DataHub page is replaced with a gmail-compose page, which then disappears once the message is sent.The fix here is adding
target="_blank"
to the anchor tag. I tried out this change and verified that behavior is what we'd want for both situations:mailto
links, they open in a new tabOther browsers:
target="_blank"
formailto
links. If we'd like to fix this for Firefox, we can do it in javascript withwindow.open
but that's a rabbit hole. I don't think we should worry about it, considering its relative lowusage, but happy to work on it if we think it's necessary.
To test this out:
mail.google.com
fromchrome://settings/handlers
and reload the gmail pageChecklist