Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(search): fix custom search config parsing #8010

Merged
merged 1 commit into from
May 10, 2023
Merged

fix(search): fix custom search config parsing #8010

merged 1 commit into from
May 10, 2023

Conversation

david-leifker
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

david-leifker
david-leifker commented May 10, 2023
View reviewed changes
metadata-io/src/main/java/com/linkedin/metadata/config/search/CustomConfiguration.java
@@ -14,28 +13,26 @@


@Data
@AllArgsConstructor
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot use this, it will break configuration parsing. This is the root cause of the bug.

@github-actions github-actions bot added devops PR or Issue related to DataHub backend & deployment product PR or Issue related to the DataHub UI/UX labels May 10, 2023
@david-leifker david-leifker enabled auto-merge (squash) May 10, 2023 14:53
@david-leifker david-leifker merged commit cd819bd into datahub-project:master May 10, 2023
37 checks passed
gabe-lyons pushed a commit to gabe-lyons/datahub that referenced this pull request Jun 13, 2023
@david-leifker
fix(search): fix custom search config parsing (datahub-project#8010)
01353c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedro93 pedro93 pedro93 approved these changes

@iprentic iprentic Awaiting requested review from iprentic

@RyanHolstien RyanHolstien Awaiting requested review from RyanHolstien

@anshbansal anshbansal Awaiting requested review from anshbansal

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@david-leifker @pedro93