Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/looker): don't prematurely show connectivity success #8070

Merged
merged 1 commit into from May 18, 2023
Merged

fix(ingest/looker): don't prematurely show connectivity success #8070

merged 1 commit into from May 18, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented May 17, 2023

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label May 17, 2023
@hsheth2 hsheth2 merged commit 48b856c into datahub-project:master May 18, 2023
47 checks passed
@hsheth2 hsheth2 deleted the looker-test-connection branch May 18, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hsheth2 @jjoyce0510