feat(ingest/s3): type aware directory sorting #8089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
…s not a partition column
5 tasks
asikowitz
approved these changes
May 22, 2023
Comment on lines
+197
to
+200
| if num_folder1 == num_folder2: | ||
| return 0 | ||
| else: | ||
| return 1 if num_folder1 > num_folder2 else -1 |
There was a problem hiding this comment.
I believe this can be more concisely num_folder1 - num_folder2
Comment on lines
+190
to
+193
| if "=" in folder1 and "=" in folder2: | ||
| if folder1.split("=", 1)[0] == folder2.split("=", 1)[0]: | ||
| folder1 = folder1.split("=", 1)[1] | ||
| folder2 = folder2.split("=", 1)[1] |
There was a problem hiding this comment.
What's the structure of these folder names? Is this preferred over using .rsplit("=", 1), which seems maybe more flexible in case the folders have multiple equal signs
There was a problem hiding this comment.
Hive partitioning is usually like :
mydir/2022/12/11
or like this:
mydir/year=2022/month=12/day=11
Hive partitioning is usually like : I think these are the most common ones and for the others it should be fine to compare as string |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding comparator to dir sorting which can sort dirs as numbers if it is number
Checklist