feat(ingest/nifi): kerberos authentication #8097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
asikowitz
reviewed
May 22, 2023
metadata-ingestion/setup.py
Outdated
| @@ -57,7 +57,7 @@ def get_long_description(): | |||
| "requests_file", | |||
| "jsonref", | |||
| "jsonschema", | |||
| "ruamel.yaml" | |||
| "ruamel.yaml", | |||
There was a problem hiding this comment.
formatting with black added this comma.
asikowitz
previously approved these changes
May 23, 2023
| @@ -112,13 +116,30 @@ class NifiSourceConfig(EnvConfigMixin): | |||
|
|
|||
| # Required to be set if nifi server certificate is not signed by | |||
| # root CA trusted by client system, e.g. self-signed certificates | |||
| ca_file: Optional[str] = Field( | |||
| ca_file: Optional[Union[bool, str]] = Field( | |||
There was a problem hiding this comment.
In case, we do not wish to provide the certificate but simply disable the ssl verification, this can be set to False.
There was a problem hiding this comment.
Passed as verify flag on requests api .
asikowitz
approved these changes
May 24, 2023
|
rip I think the merge pre-empted itself :( only 1 test was left |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist