Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/build): setting typing extension <4.6.0 because it breaks tests #8108

Merged
merged 1 commit into from May 23, 2023
Merged

fix(ingest/build): setting typing extension <4.6.0 because it breaks tests #8108

merged 1 commit into from May 23, 2023

Conversation

treff7es
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label May 23, 2023
pedro93
pedro93 approved these changes May 23, 2023
View reviewed changes
Copy link
Collaborator

@pedro93 pedro93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming green CI

@anshbansal anshbansal merged commit 4ca7a9b into datahub-project:master May 23, 2023
45 checks passed
svdimchenko pushed a commit to svdimchenko/datahub that referenced this pull request May 24, 2023
@treff7es @svdimchenko
fix(ingest/build): setting typing extension <4.6.0 because it breaks …
be3f0a4 
…tests (datahub-project#8108)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedro93 pedro93 pedro93 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@treff7es @pedro93 @anshbansal