fix(glue): fix typo in reported warning, report with flow_urn #8138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
mayurinehate
commented
Jun 2, 2023
| def get_dataflow_graph(self, script_path: str) -> Optional[Dict[str, Any]]: | ||
| def get_dataflow_graph( | ||
| self, script_path: str, flow_urn: str | ||
| ) -> Optional[Dict[str, Any]]: | ||
| """ |
There was a problem hiding this comment.
Tracking is easier with key flow_urn. script_path is already present in reported message.
mayurinehate
commented
Jun 2, 2023
| self.report.report_failure( | ||
| script_path, | ||
| self.report_warning( | ||
| flow_urn, | ||
| f"Unable to download DAG for Glue job from {script_path}, so job subtasks and lineage will be missing: {e}", |
There was a problem hiding this comment.
If the glue script can not be accessed due to some reason (missing permission - 403 Or missing script - 404), treat this as warning than error.
asikowitz
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log warnings and failures. We lose some warnings/failures due to Lossy nature of report.failures and report.warnings, in case there are more than 10 elements.
Checklist