fix(ingestion/looker): ingest looks not part of dashboard #8140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
hsheth2
requested changes
Jun 5, 2023
metadata-ingestion/src/datahub/ingestion/source/looker/looker_config.py
Outdated
Show resolved
Hide resolved
| ) | ||
| ) | ||
| # Add soft deleted looks | ||
| looks.extend(self.search_looks(fields=fields, deleted=True)) |
There was a problem hiding this comment.
why are we including soft-deleted looks?
There was a problem hiding this comment.
We have config to include soft deleted Dashboards source_config.include_deleted.
I put a condition on line 214 to add soft deleted looks if include_deleted is set
metadata-ingestion/src/datahub/ingestion/source/looker/looker_source.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/looker/looker_source.py
Outdated
Show resolved
Hide resolved
| self.client_stats.search_looks_calls += 1 | ||
| return list( | ||
| self.client.search_looks( | ||
| fields=self.__fields_mapper(fields), |
There was a problem hiding this comment.
just an fyi - python convention is to use a single _ for private methods. the double underscore __method has a different meaning and should be avoided
metadata-ingestion/src/datahub/ingestion/source/looker/looker_source.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/looker/looker_source.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/looker/looker_source.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/looker/looker_source.py
Outdated
Show resolved
Hide resolved
hsheth2
reviewed
Jun 6, 2023
| @@ -135,7 +135,8 @@ class LookerDashboardSourceConfig( | |||
| description="Patterns for selecting chart ids that are to be included", | |||
| ) | |||
| include_deleted: bool = Field( | |||
| False, description="Whether to include deleted dashboards." | |||
| False, | |||
| description="Whether to include deleted dashboards and deleted independent looks.", | |||
There was a problem hiding this comment.
Suggested change
| description="Whether to include deleted dashboards and deleted independent looks.", | |
| description="Whether to include deleted dashboards and looks.", |
| @@ -1196,6 +1203,8 @@ def extract_independent_looks(self) -> Iterable[MetadataWorkUnit]: | |||
| dashboard_element=dashboard_element | |||
| ) | |||
|
|
|||
| self.reporter.report_stage_end("extract_independent_looks") | |||
There was a problem hiding this comment.
The indentation is off here
hsheth2
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.