feat(ingest/bigquery_v2): enable platform instance using project id #8142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
asikowitz
approved these changes
Jun 5, 2023
| @@ -142,7 +142,7 @@ def cleanup(config: BigQueryV2Config) -> None: | |||
| @support_status(SupportStatus.CERTIFIED) | |||
| @capability( | |||
| SourceCapability.PLATFORM_INSTANCE, | |||
| "Not supported since BigQuery project ids are globally unique", | |||
| "Configurable platform instance is still not supported. Platform instance is always added using project id value", | |||
There was a problem hiding this comment.
The comment "still not supported" implies to me that it may be supported in the future.
Suggested change
| "Configurable platform instance is still not supported. Platform instance is always added using project id value", | |
| "Platform instance is pre-set to the BigQuery project id", |
| ) | ||
| get_tables_for_dataset.return_value = iter([bigquery_table]) | ||
|
|
||
| source_config_dict: Dict[str, Any] = {"project_ids": ["project-id-1"]} |
There was a problem hiding this comment.
Should turn off usage and lineage ingestion to prevent any request attempts, but this works for now
|
Thanks for your contribution! |
asikowitz
added a commit
to asikowitz/datahub
that referenced
this pull request
Jun 8, 2023
…ect id (datahub-project#8142)" This reverts commit 743439c.
asikowitz
added a commit
to asikowitz/datahub
that referenced
this pull request
Jun 12, 2023
…atahub-project#8142) Co-authored-by: Andrew Sikowitz <andrew.sikowitz@acryl.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist