Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): Fix modeldocgen; bump feast to relax pyarrow constraint #8178

Merged
merged 2 commits into from
Jun 6, 2023
Merged

fix(ingest): Fix modeldocgen; bump feast to relax pyarrow constraint #8178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
850d541
fix(ingest): Fix modeldocgen; bump feast to relax pyarrow constraint
asikowitz Jun 6, 2023
18e0508
fix test
asikowitz Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metadata-ingestion/scripts/modeldocgen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,7 @@ def generate(
]

relationship_graph = RelationshipGraph()
mcps = generate_stitched_record(relationship_graph)
mcps = list(generate_stitched_record(relationship_graph))

shutil.rmtree(f"{generated_docs_dir}/entities", ignore_errors=True)
entity_names = [(x, entity_registry[x]) for x in generated_documentation]
Expand Down
5 changes: 2 additions & 3 deletions metadata-ingestion/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,7 @@ def get_long_description():
# because it may break Airflow users that need SQLAlchemy 1.3.x.
"SQLAlchemy<1.4.42",
# See https://github.com/snowflakedb/snowflake-connector-python/pull/1348 for why 2.8.2 is blocked
# Cannot upgrade to 3.0.0 because of dependency on pyarrow>=10.0.1, conflicts with feast
"snowflake-connector-python!=2.8.2, <3.0.0",
"snowflake-connector-python!=2.8.2",
"pandas",
"cryptography",
"msal",
Expand Down Expand Up @@ -302,7 +301,7 @@ def get_long_description():
# https://github.com/elastic/elasticsearch-py/issues/1639#issuecomment-883587433
"elasticsearch": {"elasticsearch==7.13.4"},
"feast": {
"feast~=0.29.0",
"feast>=0.30.2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this as a ~= dep. it's a bit more controlled

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do in separate PR so I can fix CI first

"flask-openid>=1.3.0",
# typeguard 3.x, released on 2023-03-14, seems to cause issues with Feast.
"typeguard<3",
Expand Down
1 change: 1 addition & 0 deletions metadata-ingestion/tests/integration/feast/feature_store/feature_store.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ online_store:
offline_store:
type: file
entity_key_serialization_version: 2
registry: "data/registry.db"
Loading