feat(graphql) Prevent duplicate glossary term names within a group #8187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaeilers
approved these changes
Jun 7, 2023
| ); | ||
| } | ||
|
|
||
| private EntityClient initMockClient() throws Exception { |
There was a problem hiding this comment.
You could probably repurpose this for the testGetFailureExistingTermSameName if you support passing in a SearchResult and a result Hashmap
There was a problem hiding this comment.
oh you right
joshuaeilers
reviewed
Jun 7, 2023
| filter, | ||
| null, | ||
| 0, | ||
| 1000, |
There was a problem hiding this comment.
Does this mean if there were more than 1000 that we might miss some in this validation?
There was a problem hiding this comment.
that is correct. in reality it's extremely unlikely that anyone has more than 1000 entities inside of one term group / folder... but paginating here might make sense just to guard against unexpected use cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check when creating Glossary Terms to ensure that there are no other terms within the same term group (or at the root level if the new term is going to be at the root level) that have the same name.
Checklist