feat(patch): support datajob input output #8190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanHolstien
added
the
platform
github-actions
bot
added
the
ingestion
jjoyce0510
reviewed
Jun 8, 2023
| System.out.println(response.get().getResponseContent()); | ||
|
|
||
| } catch (URISyntaxException | IOException | ExecutionException | InterruptedException e) { | ||
| System.out.println(Arrays.asList(e.getStackTrace())); |
There was a problem hiding this comment.
Do we want this system out?
There was a problem hiding this comment.
Yep, this test is more of an example usage for the Java SDK. It's set to ignore for CI and the System.out gives output of what happens during local testing.
shirshanka
reviewed
Jun 9, 2023
| return this; | ||
| } | ||
|
|
||
| private ObjectNode createEdgeValue(Urn urn) { |
There was a problem hiding this comment.
This forces the timestamp for the added edge to be current time, which doesn't work if the producer wants to set a different time (e.g. processing an audit log and finding a job that was run a day ago). We need to expand the API to support passing in the full edge as well. Perhaps there can be a default implementation like this as a shortcut for people who don't care.
There was a problem hiding this comment.
Sure, will add it
…stien/datahub into feat/dataJobLineagePatch
david-leifker
approved these changes
Jun 14, 2023
tusharm
pushed a commit
to tusharm/datahub
that referenced
this pull request
Jun 20, 2023
Co-authored-by: Shirshanka Das <shirshanka@apache.org> Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist