feat(ingestion/powerbi): Ingest datasets not used in PowerBI visualization(tiles/pages) #8212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
siddiquebagwan
changed the title
hsheth2
requested changes
Jun 12, 2023
| ) | ||
| cur_workspace.scan_result = workspace_metadata | ||
| cur_workspace.datasets = self._get_workspace_datasets( | ||
| cur_workspace.scan_result | ||
| ) | ||
| for value in cur_workspace.datasets.values(): | ||
| logger.info(f"Mohd = {value.name}") |
| dataset_workunits = self.mapper.generate_container_for_dataset(dataset) | ||
| for workunit in dataset_workunits: | ||
| yield workunit | ||
| yield from self.extract_datasets_as_containers() |
There was a problem hiding this comment.
i'd like to keep the self.source_config.extract_datasets_to_containers check here
There was a problem hiding this comment.
these tests are getting pretty unwieldy - is there a way we can reduce the duplication across all the golden files?
There was a problem hiding this comment.
I remove the unwanted mock data. Now this file size got reduced to 2k
… github.com:mohdsiddique/datahub into master+acr-5435-ingest-independent-datasets-powerbi
… github.com:acryldata/datahub-fork into master+acr-5435-ingest-independent-datasets-powerbi
hsheth2
approved these changes
Jun 14, 2023
|
Merging because these changes aren't related to the kafka docker build failure |
tusharm
pushed a commit
to tusharm/datahub
that referenced
this pull request
Jun 20, 2023
…ation(tiles/pages) (datahub-project#8212) Co-authored-by: MohdSiddiqueBagwan <mohdsiddique.bagwan@gslab.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.