feat(stats): make rowcount more human readable #8232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaeilers
commented
Jun 13, 2023
|
|
||
| return intlFormat(num); | ||
| }; | ||
| export const needsFormatting = (num: number) => isThousands(num); |
There was a problem hiding this comment.
Started down a path of trying to check equality of 3500 vs 3.5K and with internationalization in play (Intl.NumberFormat) I don't feel like parsing here is going to be super reliable on machines with other languages. Future improvement to make for sure.
shirshanka
approved these changes
Jun 14, 2023
chriscollins3456
approved these changes
Jun 14, 2023
joshuaeilers
deleted the
feature/prd-340-show-20k-records-instead-of-actual-number
branch
tusharm
pushed a commit
to tusharm/datahub
that referenced
this pull request
Jun 20, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formats the numeric display for the row count (10K, 10M, etc) like other numbers around Datahub. At some point we will want to consolidate
src/utils/formatter/index.tsandsrc/app/shared/formatNumber.ts. They're similar but not quite, one uses theIntl.NumberFormatwhich may be a more flexible approach.To still provide a way for users to get to the true number values in the UI, you can still hover the row/cols and they'll expand. A tooltip was another approach that felt a little too busy on the UI and covers up the dataset name. This feels a little more out of the way and inline with the rest of the content. I didn't refactor all the fields to use this new approach right away because that would take quite a bit more time and we'll want to see how people feel about this new approach before building upon it further (or rolling it back).
Screen.Recording.2023-06-14.at.9.27.51.AM.mov
Autocomplete
Checklist