Support de-selecting browse paths #8242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
devops
joshuaeilers
force-pushed
the
je--deselect-browse-paths
branch
from
c03f890
to
16ab307
Compare
joshuaeilers
commented
Jun 21, 2023
| @@ -115,8 +115,6 @@ describe("search", () => { | |||
| }); | |||
| cy.get("[data-testid=browse-node-jaffle_shop]").click({ force: true }); | |||
|
|
|||
| // ensure expected dataset is there with expected filters applied | |||
| cy.contains("customers"); | |||
There was a problem hiding this comment.
This felt like something ported from another test, but lemme know if it's needed for some reason.
github-actions
bot
removed
the
devops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on https://github.com/acryldata/datahub-fork/pull/1438.
This just clears the entity/env/platform/browse filters if a user clicks on a path that was already selected.
Also adds a cypress test and removes a couple lines from the existing test I suspect we did not need.