Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GreatExpections): AssertionRunEventClass does not match the examp… #8243

Merged
merged 20 commits into from
Jul 19, 2023

Conversation

JifeiMei
Copy link
Contributor

Bug detail

The datum AssertionRunEventClass({'timestampMillis': 1686707305920, .... , AssertionResultClass({'type': 'SUCCESS', 'rowCount': 206, 'missingCount': None, 'unexpectedCount': 0.0, 'actualAggValue': None, 'nativeResults': {}, 'externalUrl': None}), 'runtimeContext': None}) is not an example of the schema { ..... .}

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jun 15, 2023
@mayurinehate
Copy link
Collaborator

Hey @JifeiMei can you fix the style ? CI shows lint failures.


-                    rowCount=None if result.get("element_count") is None else int(result.get("element_count")),
-                    missingCount=None if result.get("missing_count") is None else int(result.get("missing_count")),
-                    unexpectedCount=None if result.get("unexpected_count") is None else int(result.get("unexpected_count")),
+                    rowCount=None
+                    if result.get("element_count") is None
+                    else int(result.get("element_count")),
+                    missingCount=None
+                    if result.get("missing_count") is None
+                    else int(result.get("missing_count")),
+                    unexpectedCount=None
+                    if result.get("unexpected_count") is None
+                    else int(result.get("unexpected_count")),

@anshbansal anshbansal added the community-contribution PR or Issue raised by member(s) of DataHub Community label Jun 23, 2023
Add a parse_int_or_default function, cast value to int type or return a default value
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Jun 29, 2023
@jjoyce0510
Copy link
Collaborator

Looks like lint and unit tests are failing still - @JifeiMei Do you mind taking a look? We'll be able to ship once those are in good shape

@mayurinehate
Copy link
Collaborator

The lint failures are not related to changes in this PR. PR should be good to merge once CI passes.

Copy link
Collaborator

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved because Harshal had approved.

@anshbansal anshbansal merged commit 0def0e5 into datahub-project:master Jul 19, 2023
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants