-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(GreatExpections): AssertionRunEventClass does not match the examp… #8243
fix(GreatExpections): AssertionRunEventClass does not match the examp… #8243
Conversation
metadata-ingestion/src/datahub/integrations/great_expectations/action.py
Outdated
Show resolved
Hide resolved
Hey @JifeiMei can you fix the style ? CI shows lint failures.
|
metadata-ingestion/src/datahub/integrations/great_expectations/action.py
Outdated
Show resolved
Hide resolved
Add a parse_int_or_default function, cast value to int type or return a default value
Looks like lint and unit tests are failing still - @JifeiMei Do you mind taking a look? We'll be able to ship once those are in good shape |
The lint failures are not related to changes in this PR. PR should be good to merge once CI passes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved because Harshal had approved.
Bug detail
The datum AssertionRunEventClass({'timestampMillis': 1686707305920, .... , AssertionResultClass({'type': 'SUCCESS', 'rowCount': 206, 'missingCount': None, 'unexpectedCount': 0.0, 'actualAggValue': None, 'nativeResults': {}, 'externalUrl': None}), 'runtimeContext': None}) is not an example of the schema { ..... .}
Checklist